Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the using keyword per the "Explicit Resource Management" proposal #4135

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sufianrhazi
Copy link

Changes

This ECMAScript proposal adds a new keyword (using). It's reached stage 3, which is "recommended for implementation":

The change itself is very small, I've just added the using keyword to the list of keywords in src/languages/lib/ecmascript.js. I've also updated an existing keyword test adding a case to ensure using is rendered as <span class="hljs-keyword">using</span> in a declaration.

I didn't update the CHANGES.md, since I'm not sure if I should cut a new version for this? But let me know what to do and I can do it.

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md

This ECMAScript proposal adds a new keyword (`using`). It's reached
stage 3, which is "recommended for implementation"

Proposal: https://github.com/tc39/proposal-explicit-resource-management

ECMAScript proposal process: https://tc39.es/process-document/
Comment on lines +43 to +44
"extends",
"using"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"extends",
"using"
"extends",
// It's reached stage 3, which is "recommended for implementation":
"using"

Copy link
Member

@joshgoebel joshgoebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add the comment then this is good to merge!

@joshgoebel joshgoebel added the almost-there Getting close ot merging label Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
almost-there Getting close ot merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants