(objectivec) Sync preprocessor highlighting with cpp #2265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgoebel
reviewed
Nov 10, 2019
joshgoebel
reviewed
Nov 10, 2019
joshgoebel
reviewed
Nov 10, 2019
joshgoebel
approved these changes
Nov 12, 2019
The objectivec highlighting had a few bugs and was missing a few features: - Expressions with < were misidentified as a string like <stdio.h> (fixes highlightjs#1964). - Keywords like if, else, endif, etc. were not highlighted. - The escape sequences in string literals were not parsed. - Line continuations were not parsed. - Comments were not parsed. Fix all these by adapting cpp's preprocessor definition. Pull in the preprocessor test from cpp. (This is actually objectivec's first markup test. It probably could do with tests beyond just this feature.)
davidben
force-pushed
the
objc-preprocessor
branch
from
d0a879b
to
84a91e9
Compare
|
Rebased and added. |
would misbehave a bit. Given Well, then I presume it would be a poor use in that case... but that's not what we're doing here... :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objectivec highlighting had a few bugs and was missing a few
features:
Expressions with < were misidentified as a string like <stdio.h>
(fixes (c-likes) Macro including single < breaks because it thinks it's a string #1964).
Keywords like if, else, endif, etc. were not highlighted.
The escape sequences in string literals were not parsed.
Line continuations were not parsed.
Comments were not parsed.
Fix all these by adapting cpp's preprocessor definition. Pull in the
preprocessor test from cpp. (This is actually objectivec's first markup
test. It probably could do with tests beyond just this feature.)