Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix merged html attribute quoting #2235

Merged
merged 4 commits into from
Oct 30, 2019
Merged

fix merged html attribute quoting #2235

merged 4 commits into from
Oct 30, 2019

Conversation

joshgoebel
Copy link
Member

Closes #1462.

@joshgoebel joshgoebel requested a review from egor-rogov October 29, 2019 12:43
@joshgoebel joshgoebel added this to the 9.16.1 milestone Oct 29, 2019
egor-rogov
egor-rogov approved these changes Oct 30, 2019
View reviewed changes
Copy link
Collaborator

@egor-rogov egor-rogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@joshgoebel joshgoebel merged commit b7866d8 into highlightjs:master Oct 30, 2019
@joshgoebel joshgoebel deleted the fix_html_attribute_quoting branch December 6, 2019 22:03
@adibradfield adibradfield mentioned this pull request May 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egor-rogov egor-rogov egor-rogov approved these changes

Assignees
No one assigned
Labels
bug parser
Projects
None yet
Milestone
9.17
Development

Successfully merging this pull request may close these issues.

quotations marks inside HTML attributes aren't escaped properly when merging
2 participants
@joshgoebel @egor-rogov