Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Languages: SPARQL and Turtle #1553

Closed

Conversation

ellismarkf
Copy link
Contributor

Turtle is a terse RDF Triple langauge, used in the data graph space.
SPARQL is a data graph query language, and an extension of Turtle syntax.

This PR includes modes for both.

@ellismarkf
Copy link
Contributor Author

Fixing relevance issues currently breaking the build.

livescript has very few semantics counting for it, and even the default text file was not being recognized as livescript, so add extra relevance to |> character combination
@VladimirAlexiev
Copy link

VladimirAlexiev commented Apr 25, 2018

@ellismarkf Thanks! We also need highlighting for semantic languages.

  1. Is this similar to https://github.com/clarkparsia/highlight-node?
  2. Would it be possible to add Manchester notation (see the above repo)?

@isagalaev Do you have an ETA for accepting this PR? It was submitted 10 months ago.

cc @nikolatulechki

@azaroth42
Copy link

Any chance that this can be updated and reviewed?

@marcoscaceres
Copy link
Contributor

@ellismarkf, @VladimirAlexiev, @azaroth42 we are moving languages out to their own repositories, so they can be loaded externally. Then basically all you need is something like this:

https://github.com/highlightjs/highlightjs-solidity

Would some of you be willing to maintain the language? If yes, I can spin up a repository for you.

@VladimirAlexiev
Copy link

@cygri is also asking for it.

@marcoscaceres I'm willing to maintain it so please make a repo. Do we need separate repos for the 3 langs I've included: turtle, sparql and pie (the GraphDB rules lang)?

Currently CI test fails because of some silly auto detection conflict with something called arcade. I need help figuring out how to fix it; but actually I think auto detection of a gazillion langs is a bad idea and nobody needs it.
#1844

@marcoscaceres
Copy link
Contributor

@marcoscaceres I'm willing to maintain it so please make a repo. Do we need separate repos for the 3 langs I've included: turtle, sparql and pie (the GraphDB rules lang)?

Up to you how you want to manage it. It could be that they are all closely related enough to warrant a single repo. Generally, we have been doing one repo per language.

I'll set up a repo now, as "highlighjs-turtle" - but please rename it to whatever you'd like. And if you think 3 repos is best, also happy to set that up!

@marcoscaceres
Copy link
Contributor

Done: https://github.com/highlightjs/highlightjs-turtle ... please feel free to invite folks above if they'd be willing to help!

@cygri
Copy link

cygri commented Mar 14, 2019

Great to see this moving forward! Thanks @marcoscaceres and @VladimirAlexiev.

To me, Turtle and SPARQL in the same repo makes sense as they share a lot of syntax, are often used together, and are both W3C standards. Pie also shares a lot of syntax, but is a single-vendor language and has a different audience, and a different set of people who would be interested in contributing.

Either way, I can help with setting up the repo, testing and documentation, but we'll probably still need someone else to do the actual coding.

@marcoscaceres
Copy link
Contributor

@cygri, helping with basic usage documentation would really help. Take a look at https://github.com/highlightjs/highlightjs-solidity and you can basically just adapt that.

Good suggestion about Pie. I'll wait for @VladimirAlexiev for instructions on what he suggests we do - but can definitely just spin up another repository.

@VladimirAlexiev
Copy link

@marcoscaceres I don't have write access there, can't edit the description, and can't add people. Could you please give me the appropriate rights?

  • Agree with cygri, please make another repo highlightjs-pie.
  • While you're at it, also make a repo hjighlightjs-shexc and give @ericprud write rights: he did Add ShExC #2001

@marcoscaceres
Copy link
Contributor

On it!

@marcoscaceres
Copy link
Contributor

@VladimirAlexiev please navigate to
https://github.com/highlightjs/highlightjs-turtle/invitations

Once you accept, you should have admin.

@marcoscaceres
Copy link
Contributor

Done. Invites should be in your inbox.

@joshgoebel
Copy link
Member

joshgoebel commented Dec 24, 2019

Ok, I didn't see this before commenting on #1844. Glad to see we've already made some progress here!

I see we have https://github.com/highlightjs/highlightjs-turtle and https://github.com/highlightjs/highlightjs-pie now so I'm going to close both PRs as completed (since we aren't merging them and I'm trying to finally clean out all the old language PRs for the new year). Of course they both look pretty empty still, so if you all have any questions, please let us know!

To me, Turtle and SPARQL in the same repo makes sense as they share a lot of syntax, are often used together, and are both W3C standards.

I dunno if "used together" or "shares syntax" are great reasons to group them in a single repo, but if you use both and are going to help maintain them long-term and that's easier for you, then I can't grumble too much. :-)

It's also a great opportunity to figure out how to have multiple languages in a single repo. I've been working on that: #2328

I'd suggest you go with the very familiar highlight.js layout as it's familiar and my work on the new build system already supports it:

/src/languages/turtle.js
/src/languages/sparql.js
/test/detect/turtle/...
/test/detect/sparql/...

When you actually have the basic repository and files in place I'll check it out locally and can use it as a test case to flesh out my multi-language 3rd party repo support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants