Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(yaml) Tags should allow non-word characters #2486

Closed
pplantinga opened this issue Apr 9, 2020 · 2 comments · Fixed by #2487
Closed

(yaml) Tags should allow non-word characters #2486

pplantinga opened this issue Apr 9, 2020 · 2 comments · Fixed by #2487
Labels
bug good first issue Should be easier for first time contributors help welcome Could use help from community language
Milestone
10.1

Comments

@pplantinga
Copy link
Contributor

Describe the issue
YAML tags can include some non-word characters (e.g. period, dollar sign) but current highlighting only matches letters and underscores

Which language seems to have the issue?
YAML

Sample Code to Reproduce
https://jsfiddle.net/7ukmfhsv/

Expected behavior
yaml-highlight
@pplantinga pplantinga added bug help welcome Could use help from community language labels Apr 9, 2020
@joshgoebel joshgoebel added the good first issue Should be easier for first time contributors label Apr 9, 2020
@joshgoebel joshgoebel added this to the 10.1 milestone Apr 9, 2020
@joshgoebel
Copy link
Member

Confirmed. Should be a simple fix. PR welcome.

pplantinga added a commit to pplantinga/highlight.js that referenced this issue Apr 9, 2020
@pplantinga
YAML parse non-word characters as part of tags highlightjs#2486
062c81b
pplantinga added a commit to pplantinga/highlight.js that referenced this issue Apr 9, 2020
@pplantinga
Add message for highlightjs#2486 to CHANGES.md
c9c0996
@joshgoebel
Copy link
Member

@pplantinga Any chance you'd be interested in #2475? It's gotta be much simpler than this. :-)

joshgoebel pushed a commit to pplantinga/highlight.js that referenced this issue Apr 21, 2020
@pplantinga @joshgoebel
YAML parse non-word characters as part of tags highlightjs#2486
017f978
joshgoebel pushed a commit to pplantinga/highlight.js that referenced this issue Apr 21, 2020
@pplantinga @joshgoebel
Add message for highlightjs#2486 to CHANGES.md
6a5668c
@pplantinga pplantinga mentioned this issue Apr 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue Should be easier for first time contributors help welcome Could use help from community language
Projects
None yet
Milestone
10.1
Development

Successfully merging a pull request may close this issue.

(yaml) improve tag support; add verbatim tags pplantinga/highlight.js
2 participants
@joshgoebel @pplantinga