Add named tag again

highlightjs · Apr 18, 2020 · a2a2c16 · a2a2c16
1 parent e050210
commit a2a2c16
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/src/languages/yaml.js b/src/languages/yaml.js
@@ -10,12 +10,8 @@ Category: common, config
 export default function(hljs) {
   var LITERALS = 'true false yes no null';
 
-  // YAML spec allows non-reserved characters in tags, since they are intended
-  // to be used sometimes as URIs. In order to differentiate between "local"
-  // tags, prefixed with `!` and global tags, prefixed with `!!`, don't allow
-  // the prefix char `!` in the first char of the expression.
-  var NON_EXCLAMATION_CHARS = '\\w#;/?:@&=+$,.~*\\\'()[\\]'
-  var YAML_TAG_RE = '[' + NON_EXCLAMATION_CHARS + '][' + NON_EXCLAMATION_CHARS + '!]*'
+  // YAML spec allows non-reserved URI characters in tags.
+  var URI_CHARACTERS = '[\\w#;/?:@&=+$,.~*\\\'()[\\]]+'
 
   // Define keys as starting with a word character
   // ...containing word chars, spaces, colons, forward-slashes, hyphens and periods
@@ -77,13 +73,17 @@ export default function(hljs) {
         excludeEnd: true,
         relevance: 0
       },
+      { // named tags
+        className: 'type',
+        begin: '!\\w+!' + URI_CHARACTERS,
+      },
       { // local tags
         className: 'type',
-        begin: '!' + YAML_TAG_RE,
+        begin: '!' + URI_CHARACTERS,
       },
       { // data type
         className: 'type',
-        begin: '!!' + YAML_TAG_RE,
+        begin: '!!' + URI_CHARACTERS,
       },
       { // fragment id &ref
         className: 'meta',

diff --git a/test/markup/yaml/tag.expect.txt b/test/markup/yaml/tag.expect.txt
@@ -6,3 +6,4 @@
 <span class="hljs-attr">key:</span> <span class="hljs-type">!!python/name:module.name</span> <span class="hljs-string">test</span>
 <span class="hljs-attr">key:</span> <span class="hljs-type">!foo2.bar</span> <span class="hljs-string">test</span>
 <span class="hljs-attr">key:</span> <span class="hljs-type">!(foo.bar?):tag</span> <span class="hljs-string">test</span>
+<span class="hljs-attr">key:</span> <span class="hljs-type">!named!tag</span> <span class="hljs-string">test</span>
diff --git a/test/markup/yaml/tag.txt b/test/markup/yaml/tag.txt
@@ -6,3 +6,4 @@ key: !!python/dict test
 key: !!python/name:module.name test
 key: !foo2.bar test
 key: !(foo.bar?):tag test
+key: !named!tag test