implement rebase workflow for rrweb #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vadman97
force-pushed
the
vadim/rebase
branch
3 times, most recently
from
0f42054
to
3d5a745
Compare
Vadman97
changed the title
Vadman97
changed the title
Vadman97
requested review from
a team,
et and
aptlin
and removed request for
a team
|
for context:
|
Vadman97
added a commit
to highlight/highlight
that referenced
this pull request
Oct 17, 2022
update to include HIG-2959 fix as well as updating rrweb fork. see highlight/rrweb#94 and highlight/rrweb#93
Vadman97
added a commit
to highlight/highlight
that referenced
this pull request
Oct 18, 2022
## Summary update to include HIG-2959 fix as well as updating rrweb fork. see highlight/rrweb#94 and highlight/rrweb#93 ## How did you test this change? Recording and replaying my own session with the new rrweb in client and frontend. Canvas recording, obfuscation, normal record/replay look good. https://frontend-pr-3200.onrender.com/1/sessions/ZvuQEPT1Hqrsmiqgb9sMrJlOheY0?page=1&query=and%7C%7Ccustom_created_at%2Cbetween_date%2C30%20days ## Are there any deployment considerations? Bumped client version to keep track of new sessions. Using https://static.highlight.run/beta/index.js to test new client for app.highlight.run recordings. Will remove beta build after this is merged.
Vadman97
added a commit
to highlight/highlight
that referenced
this pull request
Oct 18, 2022
## Summary update to include HIG-2959 fix as well as updating rrweb fork. see highlight/rrweb#94 and highlight/rrweb#93 See #3200 Fixed by reverting rrweb-io/rrweb#962 which causes problems. Will be pointing out the observers issue there. This also cleans up some client state logic which should make sure we do not call `rrweb.addCustomEvent` which we are not recording ## How did you test this change? Before:  After:  ## Are there any deployment considerations? Bumped client version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Groups highlight changes in d3dff5e to make the rrweb repo rebase friendly.
Updates our fork up to 2286c11