HIFI-630 Server notifies client why it's disconnecting, and client disables reconnect on kick #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 16, 2021 12:16
…sables reconnect on kick.
sabrina-shanman
suggested changes
Aug 16, 2021
| * set to true, a connection that is disconnected via a purposeful server-side | ||
| * action (e.g. a "kick") will be automatically reconnected. (However, connections | ||
| * that are explicitly closed from the client side via the `disconnectFromHiFiAudioAPIServer()` | ||
| * method will stay closed.) |
There was a problem hiding this comment.
Maybe we should update this comment to explicitly mention that the client will not attempt to reconnect if HiFiConnectionAttemptResult.disableReconnect is true. (The comments in this class are included in the JS API docs)
| @@ -271,6 +276,7 @@ export class HiFiMixerSession { | |||
| this._lastSuccessfulInputAudioMutedValue = false; | |||
| this.onMuteChanged = onMuteChanged; | |||
| this._getUserFacingConnectionState = getUserFacingConnectionState; | |||
| this._disableReconnect = false; | |||
There was a problem hiding this comment.
_disableReconnect should also be set to false when the client intentionally connects, i.e. through HiFiCommunicator.connectToHiFiAudioAPIServer
sabrina-shanman
previously approved these changes
Aug 17, 2021
AndrewMeadows
previously approved these changes
Aug 17, 2021
roxanneskelly
dismissed stale reviews from AndrewMeadows and sabrina-shanman
via
ea4c1f7
sabrina-shanman
approved these changes
Aug 17, 2021
AndrewMeadows
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.