-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SSHClient.authPassword on FreeBSD #815
Conversation
FreeBSD "keyboard-interactive" prompt is "Password for user@host:"
Codecov Report
@@ Coverage Diff @@
## master #815 +/- ##
============================================
+ Coverage 64.65% 64.88% +0.22%
- Complexity 1461 1468 +7
============================================
Files 210 210
Lines 8537 8537
Branches 781 781
============================================
+ Hits 5520 5539 +19
+ Misses 2606 2591 -15
+ Partials 411 407 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
However, Linux-PAM sends the message |
All previous prompts are still matched, so "Password: " from Linux continues to work. It would just match the default remote PAM prompt of FreeBSD, too. Everyone can initialize AuthKeyboardInteractive with a PasswordResponseProvider with their own pattern (this is what we currently do), so this change is not really necessary. I just thought it would be nice to share this so other users wouldn't have to find this out when trying to connect to FreeBSD. The "password" method is disabled by default on FreeBSD, so "keyboard-interactive" is used for password authentication. |
Yes indeed, currently it's already relatively simple to provide your own pattern. Now I'm not against making the pattern more lenient, but let's at least introduce some tests for the different prompts. |
Indeed, I will add a test. |
c82b489
to
8fc6f1f
Compare
FreeBSD "keyboard-interactive" prompt is "Password for user@host:"