Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to query for server extensions available. #591

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

dkocher
Copy link
Contributor

@dkocher dkocher commented Jun 5, 2020

Fix for #590.

@dkocher dkocher requested a review from hierynomus as a code owner June 5, 2020 08:58
@hierynomus
Copy link
Owner

Shouldn't we also be checking the server extensions when doing extended requests?

@dkocher
Copy link
Contributor Author

dkocher commented Jun 5, 2020

Shouldn't we also be checking the server extensions when doing extended requests?

I think that should be the responsibility of the user. We use it like

if supportsServerExtension("statvfs", "openssh.com")
    newExtendedRequest("[email protected]")

@hierynomus
Copy link
Owner

Shouldn't we also be checking the server extensions when doing extended requests?

I think that should be the responsibility of the user. We use it like

if supportsServerExtension("statvfs", "openssh.com")
    newExtendedRequest("[email protected]")

It would actually be good to guard against sending bad requests to the server, as we know which extended requests are available. I'll add that in a separate PR and merge this one, as it is a pre-existing situation.

@hierynomus hierynomus merged commit 2d8af5a into hierynomus:master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants