Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converts bouncycastle OSGi dep from Import-Bundle to Import-Package #295

Merged
merged 4 commits into from
Jan 24, 2017

Conversation

adagios
Copy link
Contributor

@adagios adagios commented Jan 12, 2017

Another attempt at resolving #255

Import-Bundle is generally discouraged by OSGi best practices.

See http://stackoverflow.com/questions/1865819/when-should-i-use-import-package-and-when-should-i-use-require-bundle for more info.

@hierynomus
Copy link
Owner

You've forgotten com.hierynomus.sshj ;)

@15knots does it work for you too?

@adagios
Copy link
Contributor Author

adagios commented Jan 12, 2017

I wrote on the original bug:

With regards to exporting com.hierynomus.sshj packages, is it something that clients should use directly? I looked and they seemed like internal classes, so I left them out of the Export-Package.

should I add it?

@hierynomus
Copy link
Owner

Yes, you'd need them if you want to customize the config to use specific algorithms only

@adagios
Copy link
Contributor Author

adagios commented Jan 12, 2017

done!

@hierynomus
Copy link
Owner

OSGI n00b question: Should we then not also add a negative Import-Package rule for com.hierynomus.sshj?

@adagios
Copy link
Contributor Author

adagios commented Jan 12, 2017

All exported packages are normally also imported to prevent multiple class spaces.

See http://blog.osgi.org/2007/04/importance-of-exporting-nd-importing.html for a thorough explanation .

@hierynomus hierynomus merged commit 65b3003 into hierynomus:master Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants