fix: rework examples #2646
Merged
fix: rework examples #2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2646 +/- ##
==========================================
+ Coverage 84.81% 84.85% +0.04%
==========================================
Files 284 284
Lines 71281 71281
==========================================
+ Hits 60457 60487 +30
+ Misses 10824 10794 -30 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: Ivaylo Nikolov <[email protected]>
ivaylonikolov7
force-pushed
the
feat/fix-examples
branch
2 times, most recently
from
376b9db to
5cccb97
Compare
|
This was referenced Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Uncomments non-working example after the latest changes and applies necessary changes for them to work again.
Fixes #2619
Notes for reviewer:
Removed the last steps in the example(where we add the signatures) because after the latest sig map changes adding back the signatures after using
removeSignaturefunctionalities create unnecessary code gymnastics.Checklist