Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TCK): Add TokenUpdate method #2623

Merged

Conversation

ivaylogarnev-limechain
Copy link
Contributor

Description:
This PR implements the TokenUpdate JSON-RPC method and successfully validated its functionality through comprehensive tests within the TCK project.

Related issue(s):
#2622

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.78%. Comparing base (ac66099) to head (e792185).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2623      +/-   ##
==========================================
- Coverage   84.79%   84.78%   -0.02%     
==========================================
  Files         284      284              
  Lines       71253    71253              
==========================================
- Hits        60421    60409      -12     
- Misses      10832    10844      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
38.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

0xivanov
0xivanov previously approved these changes Nov 12, 2024
Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: ivaylogarnev-limechain <[email protected]>
@ivaylogarnev-limechain ivaylogarnev-limechain force-pushed the feat/tck-implement-token-update-transaction-method branch from 3f17e9f to 3713f29 Compare December 4, 2024 13:51
Copy link

sonarqubecloud bot commented Dec 9, 2024

@ivaylogarnev-limechain ivaylogarnev-limechain merged commit 883c74a into main Dec 9, 2024
8 checks passed
@ivaylogarnev-limechain ivaylogarnev-limechain deleted the feat/tck-implement-token-update-transaction-method branch December 9, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants