Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: file append transaction id after deserialization #2583

Merged
merged 9 commits into from
Oct 16, 2024

Conversation

SvetBorislavov
Copy link
Contributor

@SvetBorislavov SvetBorislavov commented Oct 15, 2024

Description:
This pull request:

  • Fixes the lost transaction ID after deserialization, if previously set
  • Adds chunk interval property to bring flexibility to the interval between chunks. This is helpful if a user tries to update a file that will take longer than the transaction's validDuration.

Related issue(s):

Fixes Partially #2167

Checklist

  • Documented (Code comments)
  • Tested (unit, integration)

@SvetBorislavov SvetBorislavov requested review from a team as code owners October 15, 2024 10:34
Signed-off-by: Svetoslav Borislavov <[email protected]>
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.45%. Comparing base (34ffa6b) to head (93af224).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2583   +/-   ##
=======================================
  Coverage   84.45%   84.45%           
=======================================
  Files         283      283           
  Lines       71038    71088   +50     
=======================================
+ Hits        59993    60037   +44     
- Misses      11045    11051    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ivaylonikolov7 ivaylonikolov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution: 🙌 The chunk interval is an awesome feature.

@SvetBorislavov SvetBorislavov force-pushed the fix-file-append-transaction-id branch from 27def54 to 7a5a1d9 Compare October 15, 2024 13:11
Copy link

Copy link
Contributor

@ivaylonikolov7 ivaylonikolov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants