-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: file append transaction id after deserialization #2583
Conversation
Signed-off-by: Svetoslav Borislavov <[email protected]>
Signed-off-by: Svetoslav Borislavov <[email protected]>
Signed-off-by: Svetoslav Borislavov <[email protected]>
…erialization Signed-off-by: Svetoslav Borislavov <[email protected]>
Signed-off-by: Svetoslav Borislavov <[email protected]>
Signed-off-by: Svetoslav Borislavov <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2583 +/- ##
=======================================
Coverage 84.45% 84.45%
=======================================
Files 283 283
Lines 71038 71088 +50
=======================================
+ Hits 59993 60037 +44
- Misses 11045 11051 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution: 🙌 The chunk interval is an awesome feature.
Signed-off-by: Svetoslav Borislavov <[email protected]>
27def54
to
7a5a1d9
Compare
Signed-off-by: Svetoslav Borislavov <[email protected]>
Signed-off-by: Svetoslav Borislavov <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
This pull request:
validDuration
.Related issue(s):
Fixes Partially #2167
Checklist