Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create additional from/to bytes tests - part 3 #1222

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

0xivanov
Copy link
Contributor

@0xivanov 0xivanov commented Jan 17, 2025

Fixes

  1. sdk/schedule_create_transaction.go
  2. sdk/system_delete_transaction.go
  3. sdk/token_create_transaction.go

Related issue: #1088

@0xivanov 0xivanov self-assigned this Jan 17, 2025
@0xivanov 0xivanov requested review from a team as code owners January 17, 2025 14:30
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 90.27778% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
sdk/system_delete_transaction.go 33.33% 3 Missing and 1 partial ⚠️
sdk/token_create_transaction.go 93.18% 2 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
sdk/schedule_create_transaction.go 94.55% <100.00%> (+0.57%) ⬆️
sdk/token_create_transaction.go 94.30% <93.18%> (-0.41%) ⬇️
sdk/system_delete_transaction.go 71.68% <33.33%> (-3.54%) ⬇️

... and 4 files with indirect coverage changes

@0xivanov 0xivanov merged commit 04ae587 into main Jan 20, 2025
6 checks passed
@0xivanov 0xivanov deleted the create-additional-from/to-bytes-tests-2 branch January 20, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants