Incorporating fixes #5
Conversation
Correcting the viewport. Removing the multiplication factor in fontSize
| @@ -22,7 +22,7 @@ | |||
| import java.lang.reflect.Proxy; | |||
| import java.util.logging.Logger; | |||
| import java.util.zip.GZIPOutputStream; | |||
|
|
|||
| import com.google.typography.font.sfntly.FontFactory; | |||
There was a problem hiding this comment.
I wish this library don't have dependencies for other libraries. If it must have, you need to realize by using a dynamic class loading and a reflection.
There was a problem hiding this comment.
No it does not have any dependency
There was a problem hiding this comment.
A FontFactory class is not a starndard jdk class. So it will add a depedency.
| if (args[i].startsWith("-")) | ||
| { | ||
| if (args[i].equals("-debug")) | ||
| { | ||
| debug = true; |
There was a problem hiding this comment.
This break line style is inappropriate. A line break shouldn't be placed before '{' in a common java coding style.
There was a problem hiding this comment.
Sorry. I am correcting it and will update in 2nd code pull request
| } | ||
| if (height > maxHeight) { | ||
| maxHeight = height; | ||
| } | ||
| dc.setWindowExtEx(width, height, old); |
There was a problem hiding this comment.
maxWidth, maxHeight value need to be taken from dc because it restore or save
There was a problem hiding this comment.
If you could please explain in little detail, that shall be very helpful.
Adding support to read PUA chars from symbol font files.
Correcting the viewport.
Removing the multiplication factor in fontSize