Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #467

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix CI #467

wants to merge 1 commit into from

Conversation

landreman
Copy link
Contributor

The CI appears to be broken. For the extensive tests with python 3.10 and 3.11 but not 3.9, there is a failure early on when pyoculus is installed.

This PR doesn't yet have a fix, just documenting that the problem occurs even for the master branch.

@landreman landreman requested review from smiet and mbkumar January 8, 2025 20:34
@landreman
Copy link
Contributor Author

The error appears to be related to f2py:

    File "/tmp/pip-build-env-78kkn94r/overlay/lib/python3.11/site-packages/numpy/f2py/capi_maps.py", line 377, in getpydocsign
      sig = '%s : %s %s%s' % (a, opt, c2py_map[ctype], init)
                                      ~~~~~~~~^^^^^^^
  KeyError: 'void'

I seem to remember this error appearing in the simsopt CI also last summer when numpy v2 was released, but I'm not certain. @smiet @mbkumar any ideas how to fix this?

@mbkumar
Copy link
Collaborator

mbkumar commented Jan 8, 2025

Looks like numpy>=2.0 issue with pyoculus. I solved a similar issue for VMEC. Perhaps it could be replicated here. I'll do a more thorough check and get back to you.

@mbkumar
Copy link
Collaborator

mbkumar commented Jan 8, 2025

In VMEC, we moved away from numpy.distutils which is deprecated and not working properly anymore. Pyoculus is still using numpy.distutils. This approach should be updated and a more robust setup function such as the one from scikit-build should be used.
@smiet used a meson build system for SPEC. Perhaps he may be interested in using the same one for PyOculus. Otherwise, I can take the lead and update the build system to a new one based on scikit-build and cmake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants