-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates and tests user referral queries, adds GetUserReferralFees.query #10522
base: master
Are you sure you want to change the base?
Conversation
@timolegros when you review this PR, can you suggest the proper attributes in the EVM block we should be appending to events? I just added a few as examples, but probably never used by any handler. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just use the following properties:
- miner
- hash
- logsBloom
- nonce
- parentHash
- timestamp
- number
- gasUsed
Done, pls check if types are OK @timolegros |
@timolegros should we update the real chain event unit tests to make sure blocks are coming in this PR? or do you want to do that in a separate PR? |
I'm fine with doing it later. I just want to get this in fast so I can begin working on removing Ethers.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
schema looks good to me but have some questions
- Correct me if I am wrong, but on the last meeting we have agreed that we should display earnings per address, not per action (so addresses are unique in the list). Does it work this way?
- I will use GetUserReferrals for this view below. Where GetUserReferralFees should I use?
- How about sorting, pagination? In different PR?
Link to Issue
Closes: #10494
Description of Changes
"How We Fixed It"
Test Plan
Deployment Plan
Other Considerations