-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move all Web3 usage to libs/evm-protocol
#10504
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
- just a few comments about moving more protocol services that don't ref the models to the other lib for more encapsulation
- the getBlock util will have conflicts with my referrals PR, let's coordinate the merges
@Rotorsoft Though if that's what we prefer I'm fine with creating 1 client accessible web3 lib and one that's not... |
That's fine, but there are probably a couple of files that are only importing the Error type from libs/core... those can be probably moved and use JS Error instead? |
@Rotorsoft, I was only able to remove the |
Link to Issue
Closes: #7504
Description of Changes
Moved all 'Web3' imports to
libs/evm-protocols
. This will facilitate mocking + transitioning to Viem.Test Plan
Deployment Plan
Other Considerations