Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ADO.NET compatible provider names in connection settings #15

Merged

Conversation

ggeurts
Copy link

@ggeurts ggeurts commented Dec 12, 2013

Rhino-Etl expects assembly qualified type names of connection classes in the ConnectionStringSettings.ProviderName property. This deviates from regular ADO.NET usage and causes issues if connection strings in the configuration file are used by non Rhino-Etl code.

Rather than specifying in the app.config file:

<add name="test"
   connectionString="Data Source=.\SQLExpress;Initial Catalog=test;Integrated Security=SSPI;Timeout=30;"
   providerName="System.Data.SqlClient.SqlConnection, System.Data, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089"/>

The following should be sufficient:

<add name="test"
   connectionString="Data Source=.\SQLExpress;Initial Catalog=test;Integrated Security=SSPI;Timeout=30;"
   providerName="System.Data.SqlClient"/>

@tommyk
Copy link

tommyk commented Jan 2, 2014

Can we get this merged in and pushed out too nuget please?

@nathanpalmer
Copy link

Sorry guys. The holidays have been taking up my time. I should be looking at these pending requests in the next couple of days.

nathanpalmer added a commit that referenced this pull request Jan 23, 2014
Support ADO.NET compatible provider names in connection settings
@nathanpalmer nathanpalmer merged commit 6bb5786 into hibernating-rhinos:master Jan 23, 2014
@ggeurts ggeurts deleted the issue15-providername branch September 5, 2018 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants