Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HSEARCH-4214 hibernate.search.backend.version_check.enabled should be evaluated on backend startup #2550

Merged
merged 2 commits into from
Apr 23, 2021

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere commented Apr 20, 2021

* Better test method names
* More assertions
@yrodiere yrodiere force-pushed the HSEARCH-4214 branch 3 times, most recently from 3760ae0 to e318f75 Compare April 20, 2021 13:05
@yrodiere yrodiere force-pushed the HSEARCH-4214 branch 2 times, most recently from 8191b6f to a9e21de Compare April 20, 2021 15:54
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
No Duplication information No Duplication information

@fax4ever fax4ever self-assigned this Apr 23, 2021
Copy link
Contributor

@fax4ever fax4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. +1 to merge it

@fax4ever fax4ever added Waiting for CI Ready to merge once CI passes and removed Waiting for CI Ready to merge once CI passes labels Apr 23, 2021
@fax4ever fax4ever merged commit 8cb8cdb into hibernate:main Apr 23, 2021
@fax4ever
Copy link
Contributor

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants