Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1641] Tests for @Array and @Struct entity annotations #1846

Closed
wants to merge 3 commits into from

Conversation

blafond
Copy link
Member

@blafond blafond commented Jan 29, 2024

[#1641] reactive tests for @Array and @Struct entity annotations

  • Tests for @Struct currently work only for Postgres and DB2.

  • Oracle fails via `Not using JDBC... " error.

  • Other DB's fail due to ORM limitations: "Dialect does not support aggregateComponentAssignmentExpression:"

  • Tests with @Array annotations mostly work

  • SchemaValidationTestBase is failing for PG & CockroachDB testing the BigInteger[] bigIntegerArray array element

Utilized DisabledFor() reason = ..... to include info on the failed tests

@blafond blafond marked this pull request as draft January 29, 2024 22:47
Copy link
Member

@DavideD DavideD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, make sure not to add extra spaces when adding the annotations.

Based on the existing annotations we use in the tests, it should be @Array(length = 10) (and not @Array( length = 10 )

Copy link
Member

@DavideD DavideD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@DavideD
Copy link
Member

DavideD commented Feb 8, 2024

I've added a commit to this PR here: #1858

@DavideD DavideD closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants