-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1641] Tests for @Array and @Struct entity annotations #1846
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, make sure not to add extra spaces when adding the annotations.
Based on the existing annotations we use in the tests, it should be @Array(length = 10)
(and not @Array( length = 10 )
hibernate-reactive-core/src/test/java/org/hibernate/reactive/StructOnClassTest.java
Outdated
Show resolved
Hide resolved
hibernate-reactive-core/src/test/java/org/hibernate/reactive/StructOnClassTest.java
Outdated
Show resolved
Hide resolved
hibernate-reactive-core/src/test/java/org/hibernate/reactive/StructOnClassTest.java
Outdated
Show resolved
Hide resolved
hibernate-reactive-core/src/test/java/org/hibernate/reactive/StructOnElementTest.java
Outdated
Show resolved
Hide resolved
...nate-reactive-core/src/test/java/org/hibernate/reactive/schema/SchemaValidationTestBase.java
Outdated
Show resolved
Hide resolved
hibernate-reactive-core/src/test/java/org/hibernate/reactive/types/JavaTypesArrayTest.java
Outdated
Show resolved
Hide resolved
hibernate-reactive-core/src/test/java/org/hibernate/reactive/types/JavaTypesArrayTest.java
Outdated
Show resolved
Hide resolved
...ive-core/src/test/java/org/hibernate/reactive/schema/SchemaArrayTypesValidationTestBase.java
Fixed
Show fixed
Hide fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
hibernate-reactive-core/src/test/java/org/hibernate/reactive/StructEmbeddableTest.java
Outdated
Show resolved
Hide resolved
hibernate-reactive-core/src/test/java/org/hibernate/reactive/StructEmbeddableTest.java
Outdated
Show resolved
Hide resolved
hibernate-reactive-core/src/test/java/org/hibernate/reactive/schema/ArrayTypesTestEntity.java
Outdated
Show resolved
Hide resolved
...ive-core/src/test/java/org/hibernate/reactive/schema/SchemaArrayTypesValidationTestBase.java
Outdated
Show resolved
Hide resolved
hibernate-reactive-core/src/test/java/org/hibernate/reactive/types/JavaTypesArrayTest.java
Outdated
Show resolved
Hide resolved
hibernate-reactive-core/src/test/java/org/hibernate/reactive/types/JavaTypesArrayTest.java
Outdated
Show resolved
Hide resolved
hibernate-reactive-core/src/test/java/org/hibernate/reactive/types/JavaTypesArrayTest.java
Outdated
Show resolved
Hide resolved
hibernate-reactive-core/src/test/java/org/hibernate/reactive/types/JavaTypesArrayTest.java
Outdated
Show resolved
Hide resolved
hibernate-reactive-core/src/test/java/org/hibernate/reactive/types/JavaTypesArrayTest.java
Outdated
Show resolved
Hide resolved
hibernate-reactive-core/src/test/java/org/hibernate/reactive/types/JavaTypesArrayTest.java
Outdated
Show resolved
Hide resolved
I've added a commit to this PR here: #1858 |
[#1641] reactive tests for
@Array
and@Struct
entity annotationsTests for
@Struct
currently work only for Postgres and DB2.Oracle fails via `Not using JDBC... " error.
Other DB's fail due to ORM limitations:
"Dialect does not support aggregateComponentAssignmentExpression:"
Tests with
@Array
annotations mostly workSchemaValidationTestBase is failing for PG & CockroachDB testing the BigInteger[] bigIntegerArray array element
Utilized DisabledFor() reason = ..... to include info on the failed tests