Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade orm to 6.4 #1789

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Upgrade orm to 6.4 #1789

merged 1 commit into from
Nov 24, 2023

Conversation

DavideD
Copy link
Member

@DavideD DavideD commented Nov 13, 2023

Fix #1782

Requires next Hibernate ORM release

@DavideD DavideD marked this pull request as draft November 13, 2023 12:32
/**
* Execute the query
*/
default <T> CompletionStage<T> reactiveExecuteQuery(DomainQueryExecutionContext executionContext, ResultsConsumer<T, R> resultsConsumer) {

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'executionContext' is never used.
/**
* Execute the query
*/
default <T> CompletionStage<T> reactiveExecuteQuery(DomainQueryExecutionContext executionContext, ResultsConsumer<T, R> resultsConsumer) {

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'resultsConsumer' is never used.
.nonReactiveMethodCall( "<no alternative>" );
}

default <T> T executeQuery(DomainQueryExecutionContext executionContext, ResultsConsumer<T, R> resultsConsumer) {

Check notice

Code scanning / CodeQL

Missing Override annotation Note

This method overrides
SelectQueryPlan.executeQuery
; it is advisable to add an Override annotation.
@DavideD DavideD force-pushed the upgrade-orm-to-6.4 branch 2 times, most recently from dc3bcc9 to e28e36f Compare November 15, 2023 08:40
@DavideD DavideD marked this pull request as ready for review November 24, 2023 10:52
@DavideD DavideD merged commit f341f8a into hibernate:main Nov 24, 2023
19 checks passed
@DavideD DavideD deleted the upgrade-orm-to-6.4 branch November 24, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Hibernate ORM to 6.4
1 participant