Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Hibernate ORM 6.2.4.Final #1647

Merged
merged 6 commits into from
Jun 1, 2023
Merged

Upgrade to Hibernate ORM 6.2.4.Final #1647

merged 6 commits into from
Jun 1, 2023

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Jun 1, 2023

No description provided.


public InsertActionSorter() {
}

/**
* Sort the insert actions.
*/
public void sort(List<ReactiveEntityInsertAction> insertions) {
public void sort(List<ReactiveEntityInsertActionHolder> insertions) {

Check notice

Code scanning / CodeQL

Missing Override annotation

This method overrides [Sorter<ReactiveEntityInsertActionHolder>.sort](1); it is advisable to add an Override annotation.
Comment on lines +1046 to +1049
actionDelegate.getSession()
.getFactory()
.getMetamodel()
.entityPersister( action.getEntityName() )
.entityPersister( actionDelegate.getEntityName() )

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [MetamodelImplementor.entityPersister](1) should be avoided because it has been deprecated.
import org.hibernate.event.spi.EventSource;
import org.hibernate.reactive.engine.ReactiveExecutable;

public final class ReactiveEntityInsertActionHolder implements Executable, ReactiveExecutable, ComparableExecutable,

Check warning

Code scanning / CodeQL

Inconsistent compareTo

This class declares [compareTo](1) but inherits equals; the two could be inconsistent.
@Sanne Sanne merged commit a365057 into hibernate:main Jun 1, 2023
@Sanne Sanne deleted the ORM624 branch June 1, 2023 11:18
@DavideD DavideD linked an issue Jun 1, 2023 that may be closed by this pull request
@DavideD DavideD added this to the 2.0.0.Final milestone Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Hibernate ORM 6.2.4.Final
2 participants