Add Db2 #1555
Merged
Add Db2 #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some dbs return the column names uppercased
Instead of the default OffsetDateTime
This seems a bug in the D2 Vert.x Client
See eclipse-vertx/vertx-sql-client#899 Tests throw: ``` java.util.concurrent.CompletionException: java.lang.IllegalStateException: Needed to have 6 in buffer but only had 0. In JDBC we would normally block here but need to find a non-blocking solution at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:331) ~[?:?] at java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:346) ~[?:?] at java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:632) ~[?:?] at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:506) ~[?:?] at java.util.concurrent.CompletableFuture.completeExceptionally(CompletableFuture.java:2088) ~[?:?] at org.hibernate.reactive.pool.impl.Handlers.lambda$toCompletionStage$0(Handlers.java:29) ~[main/:?] at io.vertx.sqlclient.impl.SqlResultHandler.fail(SqlResultHandler.java:103) ```
Tests throw exception: ``` Parameter at position[0] with class = [io.vertx.core.buffer.impl.BufferImpl] and value = [>Eg�BӤVUfBD] can not be coerced to the expected class = [io.netty.buffer.ByteBuf] for encoding. ``` See eclipse-vertx/vertx-sql-client#1304
I'll take a look, it might be something which does not require deep knowledge of the protocol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1550
I had to disable some tests because of eclipse-vertx/vertx-sql-client#1303 and eclipse-vertx/vertx-sql-client#899
@tsegismont, do you have time to have a look at these? ^
Even with the errors, I think we can merge this.
I will keep track of the disabled tests with separate issues.