Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1516] Reenable LazyBasicFieldTest#testFetchBasicField #1537

Merged
merged 1 commit into from
Mar 27, 2023
Merged

[#1516] Reenable LazyBasicFieldTest#testFetchBasicField #1537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ...in/java/org/hibernate/reactive/persister/entity/impl/ReactiveAbstractEntityPersister.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,9 +371,8 @@ default CompletionStage<Object> reactiveInitializeLazyPropertiesFromDatastore(
statement -> getIdentifierType().nullSafeSet( statement, id, 1, session )
);

final ReactiveSingleIdArrayLoadPlan lazySelect = reactiveGetSQLLazySelectLoadPlan( fetchGroup );

return lazySelect.load( id, session )
return reactiveGetSQLLazySelectLoadPlan( fetchGroup )
.load( id, session )
.thenCompose( values -> initLazyProperty(
fieldName, entity,
session, entry,
Expand Down
2 changes: 0 additions & 2 deletions .../bytecode-enhancements-it/src/test/java/org/hibernate/reactive/it/LazyBasicFieldTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
import java.util.Collection;
import java.util.List;

import org.junit.Ignore;
import org.junit.Test;

import io.vertx.ext.unit.TestContext;
Expand All @@ -26,7 +25,6 @@ protected Collection<Class<?>> annotatedEntities() {
}

@Test
@Ignore // see https://github.com/hibernate/hibernate-reactive/issues/1516
public void testFetchBasicField(TestContext context) {
final Crew emily = new Crew();
emily.setId( 21L );
Expand Down