New main with Hibernate Reactive 2 #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will add it back latere
For testing, using a connection directly to run the queries will allow us to run the tests even if without support for Hibernate queries.
Basically everything related to queries, criteria, some id strategies, and some type mapping remove
…qmMultiTableInsertStrategy implementations
This test also fails with plain old ORM 6
The assertion of the test needed to updated to the ORM 6 generated queries (the queries as essentially the same, but the sequences and names of variables have changed). Furthermore, the custom cleanup is done because the actual test itself passes (with the updated assertion), but the DB clearing fails because of the association loading issue.
This is done because the actual test itself passes, what fails before this change is the loading of entities which occurs when the database is being cleared during test cleanup. Furthermore, fix erroneous assertion in EagerUniqueKeyTest
…oOneTest Furthermore, use property access instead of field access
…er#deleteReactive
With this change, the failing tests go from 65 to 63
The only thing that changes is the whitespaces generated by ORM
DavideD
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ava/org/hibernate/reactive/loader/ast/internal/ReactiveSingleIdEntityLoaderStandardImpl.java
Fixed
Show fixed
Hide fixed
...core/src/main/java/org/hibernate/reactive/event/impl/DefaultReactiveDeleteEventListener.java
Fixed
Show fixed
Hide fixed
...rc/main/java/org/hibernate/reactive/id/impl/EmulatedSequenceReactiveIdentifierGenerator.java
Fixed
Show fixed
Hide fixed
...rc/main/java/org/hibernate/reactive/id/impl/EmulatedSequenceReactiveIdentifierGenerator.java
Fixed
Show fixed
Hide fixed
...rc/main/java/org/hibernate/reactive/id/impl/EmulatedSequenceReactiveIdentifierGenerator.java
Fixed
Show fixed
Hide fixed
...rc/main/java/org/hibernate/reactive/id/impl/EmulatedSequenceReactiveIdentifierGenerator.java
Fixed
Show fixed
Hide fixed
...rc/main/java/org/hibernate/reactive/id/impl/EmulatedSequenceReactiveIdentifierGenerator.java
Fixed
Show fixed
Hide fixed
...rc/main/java/org/hibernate/reactive/id/impl/EmulatedSequenceReactiveIdentifierGenerator.java
Fixed
Show fixed
Hide fixed
...ava/org/hibernate/reactive/loader/ast/internal/ReactiveSingleIdEntityLoaderStandardImpl.java
Fixed
Show fixed
Hide fixed
...ava/org/hibernate/reactive/loader/ast/internal/ReactiveSingleIdEntityLoaderStandardImpl.java
Fixed
Show fixed
Hide fixed
From github-code-scanning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI will compile the project but it's not going to run the tests.
Previous stable version is available on the
1.1branch.