Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BlockingIdentifierGenerator doesn't use the right session #707

Closed
gavinking opened this issue Apr 15, 2021 · 3 comments · Fixed by #708
Closed

BlockingIdentifierGenerator doesn't use the right session #707

gavinking opened this issue Apr 15, 2021 · 3 comments · Fixed by #708
Assignees
@gavinking
Labels
bug Something isn't working
Milestone
1.0.0.CR3

Comments

@gavinking
Copy link
Member

See quarkusio/quarkus#16255.
@gavinking gavinking added the bug Something isn't working label Apr 15, 2021
@gavinking gavinking added this to the 1.0.0.CR3 milestone Apr 15, 2021
@gavinking gavinking mentioned this issue Apr 15, 2021
Closed
@DavideD DavideD changed the title BlockingIdentifierGenerator is completely broken because I suck BlockingIdentifierGenerator is broken Apr 15, 2021
@DavideD
Copy link
Member

DavideD commented Apr 15, 2021

@gavinking are you going to work on this or should I do it?

@gavinking gavinking self-assigned this Apr 15, 2021
@gavinking
Copy link
Member Author

Yes, I'm on it.

gavinking added a commit to gavinking/hibernate-reactive that referenced this issue Apr 15, 2021
@gavinking
proposed fix for hibernate#707
0882fae 
make sure that queued requests use the right session and entity args
@gavinking gavinking linked a pull request Apr 15, 2021 that will close this issue
proposed fix for #707 #708
Merged
@DavideD
Copy link
Member

DavideD commented Apr 15, 2021

Thanks

gavinking added a commit to gavinking/hibernate-reactive that referenced this issue Apr 15, 2021
@gavinking
proposed fix for hibernate#707
0f1d292 
make sure that queued requests use the right session and entity args
gavinking added a commit to gavinking/hibernate-reactive that referenced this issue Apr 15, 2021
@gavinking
when we're not using blocking, just go direct to the database
09f2d74 
related to discussion around hibernate#707

This seems right for sequences. I'm not sure about tables though.
gavinking added a commit that referenced this issue Apr 16, 2021
@gavinking
proposed fix for #707
42967a1 
make sure that queued requests use the right session and entity args
gavinking added a commit that referenced this issue Apr 16, 2021
@gavinking
when we're not using blocking, just go direct to the database
d27f7d7 
related to discussion around #707

This seems right for sequences. I'm not sure about tables though.
@DavideD DavideD changed the title BlockingIdentifierGenerator is broken BlockingIdentifierGenerator doesn't use the right session Apr 16, 2021
@DavideD DavideD mentioned this issue Apr 16, 2021
Merged
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Apr 17, 2021
@DavideD
[hibernate#707] Test for OneToOne orphan removal
aa553b5
@DavideD DavideD mentioned this issue Apr 19, 2021
Open
@Sanne Sanne mentioned this issue Apr 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gavinking gavinking

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.0.CR3
Development

Successfully merging a pull request may close this issue.

proposed fix for #707 gavinking/hibernate-reactive
2 participants
@DavideD @gavinking