Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the build for the WIP branches #2034

Closed
DavideD opened this issue Dec 13, 2024 · 1 comment
Closed

Fix the build for the WIP branches #2034

DavideD opened this issue Dec 13, 2024 · 1 comment
Assignees
@DavideD
Labels
ci Changes to the Jenkins pipeline or GitHub workflows testing Improvements to test suite
Milestone
next

Comments

@DavideD
Copy link
Member

DavideD commented Dec 13, 2024

When the build starts from the scheduler, it uses JDK 17 (the one in main) for all the branches. Fox example, see: https://github.com/hibernate/hibernate-reactive/actions/runs/12318599087/job/34383693316
@DavideD DavideD added testing Improvements to test suite ci Changes to the Jenkins pipeline or GitHub workflows labels Dec 13, 2024
@DavideD DavideD added this to the next milestone Dec 13, 2024
@DavideD DavideD self-assigned this Dec 16, 2024
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Dec 19, 2024
@DavideD
[hibernate#2034] Build with JDK 11 when required
1632584 
`workflow_dispatch` uses the workflow defined in the `main` branch.

So, we need different JDK depending on the branch we are building
using the scheduler or manually:

* Hibernate Reactive 2.* (with ORM 6) requires JDK 11
* Hibernate Reactive 3.* (with ORM 7) requires JDK 17
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Dec 19, 2024
@DavideD
[hibernate#2034] Build with JDK 11 when required
bae0ede 
`workflow_dispatch` uses the workflow defined in the `main` branch.

So, we need different JDK depending on the branch we are building
using the scheduler or manually:

* Hibernate Reactive 2.* (with ORM 6) requires JDK 11
* Hibernate Reactive 3.* (with ORM 7) requires JDK 17
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Dec 19, 2024
@DavideD
[hibernate#2034] Build with JDK 11 when required
8d036a2 
`workflow_dispatch` uses the workflow defined in the `main` branch.

So, we need different JDK depending on the branch we are building
using the scheduler or manually:

* Hibernate Reactive 2.* (with ORM 6) requires JDK 11
* Hibernate Reactive 3.* (with ORM 7) requires JDK 17
@DavideD
Copy link
Member Author

DavideD commented Dec 20, 2024

Done

@DavideD DavideD closed this as completed Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DavideD DavideD

Labels
ci Changes to the Jenkins pipeline or GitHub workflows testing Improvements to test suite
Projects
None yet
Milestone
next
Development

No branches or pull requests
1 participant
@DavideD