Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set connection pool timeout in the multi-threaded tests #1649

Closed
DavideD opened this issue Jun 1, 2023 · 0 comments · Fixed by #1650
Closed

Set connection pool timeout in the multi-threaded tests #1649

DavideD opened this issue Jun 1, 2023 · 0 comments · Fixed by #1650
Labels
testing Improvements to test suite
Milestone
2.0.1.Final

Comments

@DavideD
Copy link
Member

DavideD commented Jun 1, 2023

It's not clear why, but sometimes MultithreadedInsertionTest goes into a time out.

Configuring org.hibernate.reactive.provider.Settings.POOL_CONNECT_TIMEOUT seems to solve the issue.
It happened to me consistently with MySQL when upgrading ORM to 6.2.4 and running the build with testAll.
It happened to @blafond with the upgrade to Junit 5 on MSSQL.

It's seems related to the way we configure the test and we might need to figure out what's going in the future.
@DavideD DavideD added the testing Improvements to test suite label Jun 1, 2023
@DavideD DavideD added this to the next milestone Jun 1, 2023
@DavideD DavideD changed the title Add connection timeout to the multi-threaded tests Set connection pool timeout in the multi-threaded tests Jun 1, 2023
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jun 1, 2023
@DavideD
[hibernate#1649] Set connection pool timeout for multithreaded id gen…
7112b42 
…eration tests

I don't why, but without it, these tests can stop with a timeout
exception.

It happens to me with MySQL when I test the build with all databases
and to Barry when testing MSSQL and JUnit 5.

These tests are configured differently than the others, so it's not
a critical issue.
@DavideD DavideD mentioned this issue Jun 1, 2023
Merged
DavideD added a commit that referenced this issue Jun 1, 2023
@DavideD
[#1649] Set connection pool timeout for multithreaded id generation t…
7fdc676 
…ests

I don't why, but without it, these tests can stop with a timeout
exception.

It happens to me with MySQL when I test the build with all databases
and to Barry when testing MSSQL and JUnit 5.

These tests are configured differently than the others, so it's not
a critical issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing Improvements to test suite
Projects
None yet
Milestone
2.0.1.Final
Development

Successfully merging a pull request may close this issue.

Minor fixes DavideD/hibernate-reactive
1 participant
@DavideD