Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use net.bytebuddy.experimental=true for Java 23 testing #9299

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere commented Nov 21, 2024

Should have been part of a previous Bytebuddy upgrade, but it seems we forgot.

Backports: #9300


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


Should have been part of a previous Bytebuddy upgrade, but it seems we
forgot.
@hibernate-github-bot
Copy link

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [a7e5b67]

› This message was automatically generated.

@yrodiere
Copy link
Member Author

Seems we don't test JDK 23 on PRs, so I'll YOLO it... testing on the build of the main branch. It should work as we use bytebuddy 1.14.18 and that version supports with JDK 23.

@yrodiere yrodiere merged commit 7921473 into hibernate:main Nov 21, 2024
20 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant