Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HHH-18079 Default to minimum supported DB version when using hibernate.boot.allow_jdbc_metadata_access=false with jakarta.persistence.database-product-name #8326

Merged
merged 1 commit into from
May 7, 2024

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere commented May 6, 2024

https://hibernate.atlassian.net/browse/HHH-18079

A backport to 6.5 or a 6.6.0.Final release before mid-may would be nice, as it would allow merging quarkusio/quarkus#40474 in Quarkus and fixing a pesky warning: quarkusio/quarkus#37575

EDIT: And I really mean "nice", not "absolutely necessary". Worst case we can live without it one more month.

@yrodiere yrodiere requested a review from sebersole May 6, 2024 16:10
Copy link
Member

@sebersole sebersole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, but in general lgtm

@yrodiere
Copy link
Member Author

yrodiere commented May 7, 2024

Ah, but I just noticed this in the logs:

09:10:52,540 WARN Dialect:354 - HHH000511: The 0.0.0 version for [org.hibernate.dialect.OracleDialect] is no longer supported, hence certain features may not work properly. The minimum supported version is 19.0.0. Check the community dialects project for available legacy versions.

I'll see if I can get rid of it, too...

@yrodiere
Copy link
Member Author

yrodiere commented May 7, 2024

Ah, but I just noticed this in the logs:

09:10:52,540 WARN Dialect:354 - HHH000511: The 0.0.0 version for [org.hibernate.dialect.OracleDialect] is no longer supported, hence certain features may not work properly. The minimum supported version is 19.0.0. Check the community dialects project for available legacy versions.

I'll see if I can get rid of it, too...

Actually it's a separate problem: https://hibernate.atlassian.net/browse/HHH-18080

Let's not address this in this PR.

In particular when using hibernate.boot.allow_jdbc_metadata_access=false with jakarta.persistence.database-product-name
@yrodiere
Copy link
Member Author

yrodiere commented May 7, 2024

The only failures seem caused by Develocity (https://hibernate.zulipchat.com/#narrow/stream/132095-hibernate-infra/topic/Develocity.20failing). Tests passed. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants