Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HHH-14360 Test a fix for NPE due to non-existing previous state in bytecode enhanced dirty attribute resolving #3674

Merged
merged 1 commit into from
Dec 11, 2020
Merged

HHH-14360 Test a fix for NPE due to non-existing previous state in bytecode enhanced dirty attribute resolving #3674

merged 1 commit into from
Dec 11, 2020

Conversation

beikov
Copy link
Contributor

@beikov beikov commented Dec 9, 2020

dreab8
dreab8 approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@dreab8 dreab8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good to me 👍

@tlamr
Copy link

tlamr commented Dec 9, 2020

Running our integration tests with this change fixes the null pointer issue for us.

Thanks a lot!

@Sanne Sanne mentioned this pull request Dec 10, 2020
Closed
@Sanne
Copy link
Member

Sanne commented Dec 10, 2020

Looks straight forward, but many CI tests failed :/ I'll schedule a re-run as it doesn't seem related.

@Sanne
Copy link
Member

Sanne commented Dec 10, 2020

Re-running.. CI seems to be having a bad day.

@Sanne Sanne merged commit c915168 into hibernate:master Dec 11, 2020
@Sanne
Copy link
Member

Sanne commented Dec 11, 2020

thanks all! Merged and backported

@beikov beikov deleted the HHH-14360 branch May 22, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwgmeligmeyling jwgmeligmeyling jwgmeligmeyling approved these changes

@dreab8 dreab8 dreab8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@beikov @tlamr @Sanne @dreab8 @jwgmeligmeyling