Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correcting the url by adding port #564

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Correcting the url by adding port #564

merged 1 commit into from
Jun 17, 2019

Conversation

niteshnicholas
Copy link
Contributor

PR for bug where port not getting added to url, hence generating bad url for db connections.

@niteshnicholas niteshnicholas mentioned this pull request Jun 12, 2019
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.446% when pulling cf7f99f on grofers:redshift_url_port_added into aa8ae1f on ironmussa:master.

@argenisleon argenisleon mentioned this pull request Jun 13, 2019
Closed
@niteshnicholas
Copy link
Contributor Author

Can you merge this PR. I will create the new PR for #563 . Don't want to clutter things here.

@niteshnicholas
Copy link
Contributor Author

Kindly add the PR. I need to use this on my prod server.

@argenisleon argenisleon merged commit 95f120b into hi-primus:master Jun 17, 2019
@argenisleon
Copy link
Collaborator

argenisleon commented Jun 17, 2019 •
edited
Loading

Closes #562

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@argenisleon argenisleon argenisleon approved these changes

Assignees
No one assigned
Labels
bug testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@niteshnicholas @coveralls @argenisleon @FavioVazquez