Reimplement cumulative product NumPy functions #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you document the possible values for |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 20, 2019
940: Reimplement cumulative product NumPy functions r=hgrecco a=jthielen This PR resolves two issues from #905 that were identified in #939: First, `convert_arg` in `numpy_func.py` presumes `pre_calc_units` is a `Unit` or `None`, but there are instances where it was passed a string by way of `inputs_units` in `implement_func`. Now, any `inputs_units` as a string are converted to a `Unit` before being passed to `convert_to_consistent_units`. Second, the cumulative product functions were using `implement_func` with `input_units` set to something other than `None`, which was incorrect, since these functions have arguments that should not have units (namely `axis`). These functions have been reimplemented accordingly. - [x] Closes #939 - [x] Executed ``black -t py36 . && isort -rc . && flake8`` with no errors - [x] The change is fully covered by automated unit tests - ~~Documented in docs/ as appropriate~~ - ~~Added an entry to the CHANGES file~~ (fixup to previous change: #905) Co-authored-by: Jon Thielen <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves two issues from #905 that were identified in #939:
First,
convert_arginnumpy_func.pypresumespre_calc_unitsis aUnitorNone, but there are instances where it was passed a string by way ofinputs_unitsinimplement_func. Now, anyinputs_unitsas a string are converted to aUnitbefore being passed toconvert_to_consistent_units.Second, the cumulative product functions were using
implement_funcwithinput_unitsset to something other thanNone, which was incorrect, since these functions have arguments that should not have units (namelyaxis). These functions have been reimplemented accordingly.black -t py36 . && isort -rc . && flake8with no errorsDocumented in docs/ as appropriateAdded an entry to the CHANGES file(fixup to previous change: NEP-18 Compatibility #905)