Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wraps benchmark #1862

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Wraps benchmark #1862

merged 3 commits into from
Oct 24, 2023

Conversation

Saelyos
Copy link
Contributor

@Saelyos Saelyos commented Oct 20, 2023

In relation to #1792, I added some basic tests to cover the performances of the wrapper. I also made some small changes to improve the performances (about 3x improvement):

image

There are definitely some ways to improve it again (especially by removing the call to bind), but that would require bigger internal changes.

  • Closes # (insert issue number)
  • Executed pre-commit run --all-files with no errors
  • The change is fully covered by automated unit tests
  • Documented in docs/ as appropriate
  • Added an entry to the CHANGES file

@Saelyos Saelyos mentioned this pull request Oct 20, 2023
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 20, 2023

CodSpeed Performance Report

Merging #1862 will improve performances by ×7.8

Comparing RoseauTechnologies:warps-benchmark (a2bebe0) with master (2bdb258)

Summary

⚡ 3 improvements
✅ 418 untouched benchmarks

🆕 18 new benchmarks

Benchmarks breakdown

Benchmark master RoseauTechnologies:warps-benchmark Change
test_getattr[True-millisecond] 179.3 µs 149.2 µs +20.14%
test_getattr[True-angstrom] 178.7 µs 148.3 µs +20.54%
🆕 test_wrapper[complex_meter] N/A 627.9 µs N/A
🆕 test_wrapper[float_kilometer] N/A 775.7 µs N/A
🆕 test_wrapper[complex_kilometer] N/A 728.9 µs N/A
🆕 test_wrapper[float_meter] N/A 638.1 µs N/A
🆕 test_wrapper_nonstrict[complex_kilometer] N/A 174.3 µs N/A
🆕 test_wrapper[int_kilometer] N/A 746.2 µs N/A
🆕 test_wrapper_nonstrict[int_kilometer] N/A 187.4 µs N/A
🆕 test_wrapper_nonstrict[int_meter] N/A 181.8 µs N/A
🆕 test_wrapper_nonstrict[float_meter] N/A 179.9 µs N/A
🆕 test_wrapper[int_meter] N/A 649.7 µs N/A
🆕 test_wrapper_ret[int_kilometer] N/A 819.1 µs N/A
🆕 test_wrapper_nonstrict[complex_meter] N/A 174.1 µs N/A
🆕 test_wrapper_ret[int_meter] N/A 698.7 µs N/A
🆕 test_wrapper_ret[complex_meter] N/A 699.8 µs N/A
🆕 test_wrapper_nonstrict[float_kilometer] N/A 175.1 µs N/A
🆕 test_wrapper_ret[float_kilometer] N/A 816.6 µs N/A
🆕 test_wrapper_ret[complex_kilometer] N/A 814.9 µs N/A
🆕 test_wrapper_ret[float_meter] N/A 696.7 µs N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@Saelyos Saelyos changed the title Warps benchmark Wraps benchmark Oct 20, 2023
@hgrecco hgrecco merged commit f9e139e into hgrecco:master Oct 24, 2023
34 checks passed
@hgrecco
Copy link
Owner

hgrecco commented Oct 24, 2023

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants