-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Omission is missing when word_boundary or break_token options are used #52
Comments
@gwagener do you think you could help us out with a failing test? |
Yes please :) |
I was looking for a truncate that works like this! however, I have the same issue gwagener is experiencing. When I have this in my view: truncate works fine, but the omission won't be added. However when I remove the The same goes for |
I think I know whats happening here. Im going to write a fix for this (with the proper tests) to see what you guys think. |
Thanks @AlexGunslinger! |
When using break_token, omissions was not added in the truncated html. Fix based on hgmnz/truncate_html#57. Issue described here hgmnz/truncate_html#52
When using break_token, omissions was not added in the truncated html. Fix based on hgmnz/truncate_html#57. Issue described here hgmnz/truncate_html#52
When using break_token, omissions was not added in the truncated html. Fix based on hgmnz/truncate_html#57. Issue described here hgmnz/truncate_html#52
When using break_token, omissions was not added in the truncated html. Fix based on hgmnz/truncate_html#57. Issue described here hgmnz/truncate_html#52
When using break_token, omissions was not added in the truncated html. Fix based on hgmnz/truncate_html#57. Issue described here hgmnz/truncate_html#52
The behavior I expect is that omission is used any time the text is truncated, regardless of how the end point of the truncation is determined.
#40 had a fix for the omission missing when
break_token
is used, but was closed with no discussion for some reason.The text was updated successfully, but these errors were encountered: