Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URLSearchParams not shown in log #126

Open
liukaigsx opened this issue Mar 16, 2023 · 4 comments · May be fixed by #153
Open

URLSearchParams not shown in log #126

liukaigsx opened this issue Mar 16, 2023 · 4 comments · May be fixed by #153
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@liukaigsx
Copy link

Describe the bug
URLSearchParams not shown in log

To Reproduce
Steps to reproduce the behavior:
await axiosInstance.post('http://xxxxx/hello', new URLSearchParams({ a: 1, b: 2 }));

[Axios][Request] POST http://xxxxx/hello {}

Expected behavior
[Axios][Request] POST http://xxxxx/hello a=1&b=2
@hg-pyun
Copy link
Owner

hg-pyun commented Apr 4, 2023

@liukaigsx
Thank you for your feedback. The current implementation is not processed for objects in URLSearchParams. I'll think about supporting this part.

@hg-pyun hg-pyun added the enhancement New feature or request label Apr 4, 2023
@hg-pyun hg-pyun added the good first issue Good for newcomers label Aug 2, 2023
antirek pushed a commit to antirek/axios-logger that referenced this issue Jun 26, 2024
fix: use URLSearchParams as source for request params and data
605e2bc 
fixes hg-pyun#126
@antirek antirek linked a pull request Jun 26, 2024 that will close this issue
Open
@antirek
Copy link
Contributor

antirek commented Jun 26, 2024

@hg-pyun Hi, I add pull request. check it, please. I need this feature too.

@hg-pyun
Copy link
Owner

hg-pyun commented Jun 30, 2024

@antirek Thank you for PR!, I will see this soon.

@antirek
Copy link
Contributor

antirek commented Jul 9, 2024

@hg-pyun add some comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use URLSearchParams as source for request params and data antirek/axios-logger
3 participants
@antirek @hg-pyun @liukaigsx