feat: Add 'changedSince' option #80
Conversation
| ) | ||
| } | ||
|
|
||
| return filterChangedPackages([...data.changedFiles], this.pkgPaths, this.opts.workspacePath) |
There was a problem hiding this comment.
Is the return type Promise<PkgJson[]> ?
There was a problem hiding this comment.
No. The expandGlobs function returns Promise<string[]> (in master) so the new function filterChangedPackages has the same signature.
There was a problem hiding this comment.
ah since it .maps p => p.name first. got it.
README.md
Outdated
|
|
||
| Misc Options: | ||
| --fast-exit, e If at least one script exits with code > 0, abort [boolean] | ||
| --collect-logs, l Collect per-package output and print it at the end of each script [boolean] | ||
| --no-prefix Don't prefix output [boolean] |
There was a problem hiding this comment.
no-prefix is not removed, its a way to specify a "false" version for --prefix
There was a problem hiding this comment.
I couldn't find reference or usage anywhere in the code. Can you show me where it is used?
There was a problem hiding this comment.
this is a yargs feature when --no-xxx is the same as --xxx=false
There was a problem hiding this comment.
I've renamed the flag to be no-prefix because the documentation (when running wsrun --help) would be wrong.
The previous implementation relied on users knowing the --no-prefix yargs trick. The no-prefix line was misleading because it's written as an option but you can't add documentation for it so it's just when running wsrun --help.
There was a problem hiding this comment.
i've changed the documentation to include both --prefix and --no-prefix with explanations on their meaning.
ivasilov
force-pushed
the
add-changedSince
branch
from
b27839d
to
3b481fc
Compare
ivasilov
force-pushed
the
add-changedSince
branch
from
3b481fc
to
5230ab8
Compare
|
🎉 This PR is included in version 5.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@idan-at it depends on which additional flags you supply to it. If you run it as If you run it as You can also combine all three flags. Does that answers your question? |
|
amazing. Exactly what I needed, thank you :) |
As discussed in #58, this PR adds a new option to wsrun to only run packages which have been changed from a supplied branch. It works exactly like
jest --changedSince=master.It uses
jest-changed-filesinternally.