Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: packages dependencies & animted rename #31

Merged
merged 5 commits into from
Dec 20, 2021

Conversation

alantoa
Copy link
Contributor

@alantoa alantoa commented Dec 15, 2021

Hi, I very like this project.Now a lot of people are using react-native-reanimted v2.
Upgrading to react-native-reanimted v2 is highly recommended. 😄
So:

  • Project's react-native-reanimted version should depend on myself project.
  • fix: "WARN Easing was renamed to EasingNode in Reanimated 2. Please use EasingNode instead"

So this PR is for v2, thanks!!!

package.json Outdated Show resolved Hide resolved
@heyman333
Copy link
Owner

Thank you for your work! @MonsterAnan
I just commented on some line!
please check it!

Co-authored-by: ZERO (Yeongsu Han) <[email protected]>
@alantoa
Copy link
Contributor Author

alantoa commented Dec 18, 2021

Yea,you are right!
Thank you for you reply!

@heyman333
Copy link
Owner

@MonsterAnan
Oh I was just giving an example, I thought it would be nice

"peerDependencies": {
      "react-native-reanimated": ">=2",,
  }

could you fix it?

@alantoa
Copy link
Contributor Author

alantoa commented Dec 20, 2021

Oh,sorry, I edited it on my phone the other night, I thought you fixed it 🤣.
Now It's been fixed, I think there is no problem. 🤝 @heyman333

@heyman333 heyman333 merged commit 4688c4c into heyman333:master Dec 20, 2021
@alantoa
Copy link
Contributor Author

alantoa commented Dec 20, 2021

Hi, could you publish npm?
My project need it.
Thanks.

@heyman333
Copy link
Owner

@MonsterAnan
hey. I just published npm. Please let me know if you have ploblem.

@alantoa
Copy link
Contributor Author

alantoa commented Dec 21, 2021

thank you! 💗
I have no more problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants