Skip to content

Commit

Permalink
e2e: more debugging output for lock and elect etcdctl tests
Browse files Browse the repository at this point in the history
Meant to debug etcd-io#6464 and etcd-io#6934

Dumps the output from the etcd/etcdctl servers and SIGQUITs to get a
golang backtrace in case of a hanged process.
  • Loading branch information
Anthony Romano committed May 10, 2017
1 parent c644173 commit 300b061
Show file tree
Hide file tree
Showing 3 changed files with 34 additions and 2 deletions.
14 changes: 13 additions & 1 deletion e2e/ctl_v3_elect_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,26 @@ package e2e
import (
"os"
"strings"
"syscall"
"testing"
"time"

"github.com/coreos/etcd/pkg/expect"
)

func TestCtlV3Elect(t *testing.T) { testCtl(t, testElect) }
func TestCtlV3Elect(t *testing.T) {
oldenv := os.Getenv("EXPECT_DEBUG")
defer os.Setenv("EXPECT_DEBUG", oldenv)
os.Setenv("EXPECT_DEBUG", "1")

testCtl(t, testElect)
}

func testElect(cx ctlCtx) {
// debugging for #6934
sig := cx.epc.withStopSignal(syscall.SIGQUIT)
defer cx.epc.withStopSignal(sig)

name := "a"

holder, ch, err := ctlV3Elect(cx, name, "p1")
Expand Down Expand Up @@ -102,6 +113,7 @@ func ctlV3Elect(cx ctlCtx, name, proposal string) (*expect.ExpectProcess, <-chan
close(outc)
return proc, outc, err
}
proc.StopSignal = syscall.SIGQUIT
go func() {
s, xerr := proc.ExpectFunc(func(string) bool { return true })
if xerr != nil {
Expand Down
14 changes: 13 additions & 1 deletion e2e/ctl_v3_lock_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,26 @@ package e2e
import (
"os"
"strings"
"syscall"
"testing"
"time"

"github.com/coreos/etcd/pkg/expect"
)

func TestCtlV3Lock(t *testing.T) { testCtl(t, testLock) }
func TestCtlV3Lock(t *testing.T) {
oldenv := os.Getenv("EXPECT_DEBUG")
defer os.Setenv("EXPECT_DEBUG", oldenv)
os.Setenv("EXPECT_DEBUG", "1")

testCtl(t, testLock)
}

func testLock(cx ctlCtx) {
// debugging for #6464
sig := cx.epc.withStopSignal(syscall.SIGQUIT)
defer cx.epc.withStopSignal(sig)

name := "a"

holder, ch, err := ctlV3Lock(cx, name)
Expand Down Expand Up @@ -102,6 +113,7 @@ func ctlV3Lock(cx ctlCtx, name string) (*expect.ExpectProcess, <-chan string, er
close(outc)
return proc, outc, err
}
proc.StopSignal = syscall.SIGQUIT
go func() {
s, xerr := proc.ExpectFunc(func(string) bool { return true })
if xerr != nil {
Expand Down
8 changes: 8 additions & 0 deletions e2e/etcd_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -553,3 +553,11 @@ func (epc *etcdProcessCluster) grpcEndpoints() []string {
}
return eps
}

func (epc *etcdProcessCluster) withStopSignal(sig os.Signal) os.Signal {
ret := epc.procs[0].proc.StopSignal
for _, p := range epc.procs {
p.proc.StopSignal = sig
}
return ret
}

0 comments on commit 300b061

Please sign in to comment.