This repository has been archived by the owner on Oct 6, 2020. It is now read-only.
fix(Formbot): Update minLength and maxLength error messages #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choochootrain
requested review from
jadenlemmon,
erikshestopal and
kylealwyn
|
lol @ https://blog.npmjs.org/post/180565383195/details-about-the-event-stream-incident |
|
lgtm after checks fixed |
choochootrain
force-pushed
the
fix/validation-length-typo
branch
from
68dabb6 to
e673906
Compare
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
=======================================
Coverage 69.29% 69.29%
=======================================
Files 10 10
Lines 127 127
Branches 20 20
=======================================
Hits 88 88
Misses 28 28
Partials 11 11Continue to review full report at Codecov.
|
kylealwyn
approved these changes
Dec 1, 2018
kylealwyn
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
discovered via sappira-inc/web-app#116