Skip to content
This repository has been archived by the owner on Oct 6, 2020. It is now read-only.

fix(Linkify): Skip code block formatting #38

Merged
merged 5 commits into from
Apr 16, 2019
Merged

Conversation

cehsu
Copy link
Contributor

@cehsu cehsu commented Apr 13, 2019

These changes allow the <Linkify/> component to display text formatted as a code block (according to gfm) as normal text.

image

@cehsu cehsu requested a review from a team April 13, 2019 00:27
@codecov
Copy link

codecov bot commented Apr 13, 2019

Codecov Report

Merging #38 into master will increase coverage by 0.06%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   68.22%   68.28%   +0.06%     
==========================================
  Files          22       22              
  Lines         428      432       +4     
  Branches       90       91       +1     
==========================================
+ Hits          292      295       +3     
- Misses        106      107       +1     
  Partials       30       30
Impacted Files Coverage Δ
src/Linkify/Linkify.js 90.9% <75%> (-9.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c5d997...444e92f. Read the comment docs.

Copy link

@choochootrain choochootrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if it works in emr and web-app

@cehsu
Copy link
Contributor Author

cehsu commented Apr 15, 2019

Thanks @choochootrain, it does.

@kylealwyn kylealwyn changed the title fix(Linkify): Format code blocks fix(Linkify): Skip code block formatting Apr 15, 2019
@cehsu cehsu merged commit 620e40f into master Apr 16, 2019
@cehsu cehsu deleted the fix/linkify-text-formatting branch April 16, 2019 16:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants