This repository has been archived by the owner on Oct 6, 2020. It is now read-only.
fix(Modal): Use Transition to simplify animation; add close button; convert to hooks #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 71.91% 74.84% +2.92%
==========================================
Files 12 12
Lines 146 163 +17
Branches 19 24 +5
==========================================
+ Hits 105 122 +17
Misses 31 31
Partials 10 10
Continue to review full report at Codecov.
|
kylealwyn
changed the title
kylealwyn
changed the title
choochootrain
approved these changes
Mar 12, 2019
src/Modal/Modal.js
Outdated
| useEffect(() => { | ||
| document.addEventListener('keydown', handleKeyDown); | ||
| return () => document.removeEventListener('keydown', handleKeyDown); | ||
| }) |
There was a problem hiding this comment.
worth conditionally firing with [isOpen, props.closeOnEscape]?
There was a problem hiding this comment.
Just gave that a try. Presented weird behavior that closes both modals and reopens the second when pressing escape
cehsu
approved these changes
Mar 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.