-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
@rkrishn7 I reverted your merge because there were too many TS errors. Can you fix the TS errors and try merging again? We can try merging smaller pieces if that help. Also, you can run |
my bad, forgot to cleanup some of the tests/stories. There are a few remaining errors that are coming from There are a couple errors from & + ${Card.Body} { Not sure why we use this. |
@rkrishn7 lets create PRs to merge onto this branch. I would like to keep it error free to make it easier. Can you revert your last change since it caused errors again. |
bd7444e
to
5d0b4cc
Compare
50e739a
to
5d0b4cc
Compare
d54eb8f
to
7008e39
Compare
0646590
to
e33b3a9
Compare
import { getComponentVariant, createComponent } from '../utils'; | ||
|
||
const StyledAlert = createComponent({ | ||
export interface AlertProps extends SpaceProps { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking through a couple related PRs, I'm seeing discrepancies around defining props. Here it is an interface, elsewhere I've seen type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I normally use interface to define objects. Is there a reason why we would use type over interfaces for objects?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
📃 Summary
Refactor code to provide typings for the Webapp and EMR
🔍 Changeset
🏷 Asana Task
https://app.asana.com/0/0/1186084579231283/f
↩️ Depends On
📸 Screenshots
🧪 QA
📈 Risk Analysis