Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/hey UI 148 textarea component #92

Merged
merged 20 commits into from
Oct 19, 2022

Conversation

derek-heycar
Copy link
Contributor

Pull Request

Description

First implementation of the Textarea component.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change

How do I test this

  • Add steps to test
  • in bullet point format
  • preferably you can add link to the storybook build in the PR

Checklist

Did you remember to take care of the following?

  • npm i – for new NPM dependencies.
  • npm run lint - to check for linting issues
  • npm run test - to run unit tests
  • npm run test:sh:docker - to run screenshot tests, detail instruction

New Feature / Bug Fix

  • Run unit tests to ensure all existing tests are still passing.
  • Add new passing unit tests to cover the code introduced by your pr.

Thanks for contributing!

@auto-assign auto-assign bot requested a review from hcafaq October 5, 2022 16:15
@github-actions
Copy link

github-actions bot commented Oct 5, 2022

Compiled a new version demo.

@esraltintas
Copy link
Contributor

@derek-heycar Could you check the conflicts, please?

@github-actions
Copy link

Compiled a new version demo.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3282926855

  • 50 of 50 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 98.842%

Totals Coverage Status
Change from base Build 3242862076: -0.1%
Covered Lines: 871
Relevant Lines: 871

💛 - Coveralls

@github-actions
Copy link

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 99.79% 946/948
🟢 Branches 92.73% 153/165
🟢 Functions 100% 50/50
🟢 Lines 100% 871/871
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / Textarea.tsx
98.18% 90% 100% 100%
🟢
... / TextareaCounter.tsx
100% 100% 100% 100%

Test suite run success

228 tests passing in 32 suites.

Report generated by 🧪jest coverage report action from 323df99

@github-actions
Copy link

Compiled a new version demo.

@derek-heycar derek-heycar merged commit 9ad5d31 into main Oct 19, 2022
@derek-heycar derek-heycar deleted the feat/HEYUI-148-textarea-component branch October 19, 2022 17:34
derek-heycar pushed a commit that referenced this pull request Oct 19, 2022
# [2.7.0](v2.6.0...v2.7.0) (2022-10-19)

### Features

* **textarea:** first implementation the textarea component ([#92](#92)) ([9ad5d31](9ad5d31))
@derek-heycar
Copy link
Contributor Author

🎉 This PR is included in version 2.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants