Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(divider): add new divider component #220

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

esraltintas
Copy link
Contributor

Add new divider component

Pull Request

Description

Describe your changes (or add ticket description) and add relevant screenshots

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change

How do I test this

  • Add steps to test
  • in bullet point format
  • preferably you can add link to the storybook build in the PR

Checklist

Did you remember to take care of the following?

  • npm i – for new NPM dependencies.
  • npm run lint - to check for linting issues
  • npm run test - to run unit tests
  • npm run test:sh:docker - to run screenshot tests, detail instruction

New Feature / Bug Fix

  • Run unit tests to ensure all existing tests are still passing.
  • Add new passing unit tests to cover the code introduced by your pr.

Thanks for contributing!

Add new divider component
@esraltintas esraltintas self-assigned this Jun 13, 2023
@auto-assign auto-assign bot requested a review from nathanjamal June 13, 2023 13:33
@github-actions
Copy link

Pull Request Test Coverage Report for Build 5256142633

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 92.224%

Totals Coverage Status
Change from base Build 5212697865: 0.02%
Covered Lines: 1671
Relevant Lines: 1735

💛 - Coveralls

@github-actions
Copy link

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 96.1% 1872/1948
🟢 Branches 81.21% 523/644
🟢 Functions 82.56% 161/195
🟢 Lines 96.31% 1671/1735
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / Divider.tsx
100% 100% 100% 100%

Test suite run success

402 tests passing in 57 suites.

Report generated by 🧪jest coverage report action from 1cd362b

@github-actions
Copy link

Compiled a new version demo.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5256142633

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 92.224%

Totals Coverage Status
Change from base Build 5212697865: 0.02%
Covered Lines: 1671
Relevant Lines: 1735

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants