-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(header): reset subnav state on page change + position fixed #219
Conversation
reset subnav state on page change. Plus added a hook into the burger menu toggle event so parent app can do things like lock the page scroll when nav is open. Also changed back to position fixed for more stable sticky behaviour BREAKING CHANGE: Header changed from position sticky to position fixed HEYUI-365
Pull Request Test Coverage Report for Build 5246051666
💛 - Coveralls |
Coverage report
Test suite run success402 tests passing in 56 suites. Report generated by 🧪jest coverage report action from ae6daa4 |
Compiled a new version demo. |
# [9.0.0](v8.8.0...v9.0.0) (2023-06-14) ### Bug Fixes * **header:** reset subnav state on page change + position fixed ([#219](#219)) ([0430432](0430432)) ### BREAKING CHANGES * **header:** Header changed from position sticky to position fixed HEYUI-365 * update docs
🎉 This PR is included in version 9.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Pull Request Test Coverage Report for Build 5246051666Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
reset subnav state on page change. Plus added a hook into the burger menu toggle event so parent app can do things like lock the page scroll when nav is open. Also changed back to position fixed for more stable sticky behaviour
BREAKING CHANGE: Header changed from position sticky to position fixed
HEYUI-365
Pull Request
Description
Describe your changes (or add ticket description) and add relevant screenshots
Type of change
How do I test this
Checklist
Did you remember to take care of the following?
npm i
– for new NPM dependencies.npm run lint
- to check for linting issuesnpm run test
- to run unit testsnpm run test:sh:docker
- to run screenshot tests, detail instructionNew Feature / Bug Fix
Thanks for contributing!