Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(header): fix issue with header being full page height on mobile #209

Merged
merged 2 commits into from
May 24, 2023

Conversation

nathanjamal
Copy link
Collaborator

fix issue with header being full page height on mobile Plus updated tablet breakpoint to match designs

HEYUI-340

Pull Request

Description

Describe your changes (or add ticket description) and add relevant screenshots

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change

How do I test this

  • Add steps to test
  • in bullet point format
  • preferably you can add link to the storybook build in the PR

Checklist

Did you remember to take care of the following?

  • npm i – for new NPM dependencies.
  • npm run lint - to check for linting issues
  • npm run test - to run unit tests
  • npm run test:sh:docker - to run screenshot tests, detail instruction

New Feature / Bug Fix

  • Run unit tests to ensure all existing tests are still passing.
  • Add new passing unit tests to cover the code introduced by your pr.

Thanks for contributing!

fix issue with header being full page height on mobile Plus updated tablet breakpoint to match
designs

HEYUI-340
@auto-assign auto-assign bot requested a review from esraltintas May 24, 2023 09:21
@github-actions
Copy link

github-actions bot commented May 24, 2023

Pull Request Test Coverage Report for Build 5067202548

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.983%

Totals Coverage Status
Change from base Build 5055021805: 0.0%
Covered Lines: 1509
Relevant Lines: 1556

💛 - Coveralls

@github-actions
Copy link

Compiled a new version demo.

@github-actions
Copy link

github-actions bot commented May 24, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 96.69% 1694/1752
🟢 Branches 85.32% 459/538
🟢 Functions 82.56% 142/172
🟢 Lines 96.98% 1509/1556

Test suite run success

363 tests passing in 50 suites.

Report generated by 🧪jest coverage report action from ac472a1

@github-actions
Copy link

Compiled a new version demo.

@nathanjamal nathanjamal merged commit 0401c56 into main May 24, 2023
@nathanjamal nathanjamal deleted the HEYUI-340 branch May 24, 2023 11:26
supcar pushed a commit that referenced this pull request May 24, 2023
# [8.3.0](v8.2.2...v8.3.0) (2023-05-24)

### Bug Fixes

* **header:** fix issue with header being full page height on mobile ([#209](#209)) ([0401c56](0401c56))

### Features

* **app-store-button:** app store badges for iOS and Android ([#199](#199)) ([d0771a8](d0771a8))
@supcar
Copy link
Collaborator

supcar commented May 24, 2023

🎉 This PR is included in version 8.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants