Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix rollup css #194

Merged
merged 4 commits into from
Apr 27, 2023
Merged

chore: fix rollup css #194

merged 4 commits into from
Apr 27, 2023

Conversation

Nazzanuk
Copy link
Collaborator

Pull Request

Description

Fix incorrect bundling of css files

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change

How do I test this

  • Add steps to test
  • in bullet point format
  • preferably you can add link to the storybook build in the PR

Checklist

Did you remember to take care of the following?

  • npm i – for new NPM dependencies.
  • npm run lint - to check for linting issues
  • npm run test - to run unit tests
  • npm run test:sh:docker - to run screenshot tests, detail instruction

New Feature / Bug Fix

  • Run unit tests to ensure all existing tests are still passing.
  • Add new passing unit tests to cover the code introduced by your pr.

Thanks for contributing!

bumping versions

BREAKING CHANGE: styles now need to be imported separately
@Nazzanuk Nazzanuk added the enhancement New feature or request label Apr 27, 2023
@Nazzanuk Nazzanuk self-assigned this Apr 27, 2023
@Nazzanuk Nazzanuk merged commit 7d1fc92 into main Apr 27, 2023
@Nazzanuk Nazzanuk deleted the fix-rollup-css branch April 27, 2023 07:50
supcar pushed a commit that referenced this pull request Apr 27, 2023
# [8.0.0](v7.0.0...v8.0.0) (2023-04-27)

### chore

* fix rollup css ([#194](#194)) ([7d1fc92](7d1fc92))

### BREAKING CHANGES

* styles now need to be imported separately

* build(rollup): update to fix css exports

* build(package.json): updates to all packages to trigger version bump
@supcar
Copy link
Collaborator

supcar commented Apr 27, 2023

🎉 This PR is included in version 8.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Apr 27, 2023

Pull Request Test Coverage Report for Build 4817315555

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.008%

Totals Coverage Status
Change from base Build 4809365172: 0.0%
Covered Lines: 1247
Relevant Lines: 1264

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Apr 27, 2023

Coverage report

❌ An unexpected error occurred. For more details, check console

Error: The process '/usr/bin/git' failed with exit code 1
St.
Category Percentage Covered / Total
🟢 Statements 98.14% 1371/1397
🟢 Branches 85.35% 268/314
🟢 Functions 94.29% 99/105
🟢 Lines 98.66% 1247/1264

Test suite run success

301 tests passing in 44 suites.

Report generated by 🧪jest coverage report action from bc4e9a4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants